Never have thought such a way of shooting myself in the foot... 

I posted a few patches on: https://sourceforge.net/p/quakespasm/patches/

The most substantial one is the brush model drawing rewrite to use the world drawing code. This should fix the problem necros mentioned in the screenshots thread, where large brush models kill fps. In the unreleased telefragged.bsp, the patch doubles my fps in one place, from 18 to 36. The downside is a divergence from the original fitzquake drawing code.

The other one that's interesting is the lightmap fix for mfx's map. It turns out the dimensions of the lightmap data for each surface are calculated via a fragile floating-point calculation (something like a dot product of vertex coords and texture coords). The engine and light compiler need to do the floating-point math exactly the same.. more so than C guarantees. If my understanding is correct, this affects all engines and all compilers. For anyone compiling a map compiler, make sure it's not using SSE2 floating point, which it probably is if you build a 64-bit executable! 

skip removal tools operate differently on brushmodels than world models, relying on the fact that engines draws them differently. If you don't traverse the Surfaces list on brushmodels, and instead use Marksurfaces, skipped polygons may end up getting drawn on brushmodels. Have you checked this in any maps with known skip textures on brushmodels? 

thanks for the warning - I left the loop over the model's surfaces in R_DrawBrushModel the same as before (just replaced the call to R_DrawSequentialPoly with a new R_ChainSurface), so that still works correctly, and just verified it in a test map. 

Fixed in the quakespasm svn repository as of rev. 902:
http://sourceforge.net/p/quakespasm/code/902/ 

Thanks Eric. You're a great hacker.
I committed the new keyboard bindings.
*Sorry* - but have reversed your weapon cycle order. Be thankful i didnt bind jump to right mouse. Oz can change it back if he wants, and apply the complicated patches whatever. 

Hmmm - we're going to put the new default.cfg and the custom background image into a separate pak i think , for the next release.

Might change the background image too if i can find a decent new one.. suggestions ? They have to be 8-bit. 

I'm much in favor of clean exe (and dll if required) releases. Additional files like paks or folders are clutter. 

I'm much in favor of clean exe (and dll if required) releases. Additional files like paks or folders are clutter.

id1/quakespasm.pak is purely optional, not required for operation. The real clutter was the way we used to violate the engine for content customizations, and now not. 

Was it really necessary to include that custom background image in the first place? I mean, it's nice and all, but still. 

FWIW: if an engine has custom content, I prefer that it squirrels it away in a custom directory, rather than id1. E.g. the approach used by super8, reQuiem, Qrack, ezQuake, etc. 

including stuff like an id1/*.pak infects other engines (having to take care with numbering paks is stupid). we really don't want quakespasm branding etc in other engines because users are already stupid enough.
custom/private gamedirs are indeed the way to go if you're trying to push custom stuff for a specific engine. 

including stuff like an id1/*.pak infects other engines (having to take care with numbering paks is stupid). we really don't want quakespasm branding etc in other engines because users are already stupid enough.
custom/private gamedirs are indeed the way to go if you're trying to push custom stuff for a specific engine.

I see. How about not using any subdir for it at all and loading directly from com_basedir and/or com_userdir? 

Append it to the end of the exe if you want to be fancy about it, like self extracting zips.
Shoving it in the basedir should be safe I guess, no worse than a dll.
Either way, you might need to come up with some cunning way to not break mod-specific (as opposed to engine-specific) conbacks etc, especially if its a tga. That's more of a general problem though. meh. 

Append it to the end of the exe if you want to be fancy about it, like self extracting zips.

We used to embed the pic by perversely violating the engine, and I managed to persuade Steve about using a pak, so no, I won't do that :)

Shoving it in the basedir should be safe I guess, no worse than a dll.

Yeah, easiest and non-infectious solution, IMO.

you might need to come up with some cunning way to not break mod-specific (as opposed to engine-specific) conbacks etc, especially if its a tga. That's more of a general problem though. meh.

The pak is loaded just and only after id1/pak0.pak, so any other mod with a customized conback or anything else are safe, those include the hipnotic and rogue mission packs. 

Someone over at quaddicted reported this:
http://i.imgur.com/gvkld5W.jpg 

Seems that the issue happens with screen widths that aren't a multiple of 4. Fixed in the quakespasm svn repository at rev 909:
http://sourceforge.net/p/quakespasm/code/909/
Fix will be integrated in the next release, whenever that happens. 

Would it make sense to change the default sv_aim value to 1 in Quakespasm (to disable aim-assist)?

and maybe make it CVAR_ARCHIVE since most of the other control preferences are saved too? 

Maybe something along the lines of "if mouselook=on -> autoaim=off". 

Autoaim sucks. 

+ CVAR_ARCHIVE 

Please, add CVAR_ARCHIVE to gl_cshiftpercent
... and pretty much everything else. 

please let us "record demo", "load quick.sav" without stopping the demo record.

Fitz does it, DP does it, reQuiem does it. In fact I think it is possible in stock Quake engines too. 

there are features even i didn't know about :) 

Fitzquake does it but on my pc you have to hit the console button to make it work (otherwise it stays stuck)