Interesting looking mod :) 

Not dependent on command line, depends on compiler. The crash was due to long global strings from the progs not fitting into an 256 chars long array (a stupid sprintf crash.) Grep your saves for "STORY_??" and see.
http://quakespasm.svn.sourceforge.net/viewvc/quakespasm?view=revision&revision=791 

You said it was a QC error in my dev progs, but it's definitely a bug in the Quakespasm code. I just tested my new map in several other mods (including ID1 1.01) and it's reproducable in all of them, albeit not at every instance of the hack. No other source ports have a problem with it.

I also noticed a slightly teleporter and monsterjump behavior in comparison to Fitz085. Monsters teleported into a monsterjump trigger that worked fine in Fitz would either be kind of pushed out of the teleport destination and miss the trigger, or not be pushed in the same way (speed/height). This may or may not have to do with the fact the jump triggers are point entities using the bounds of another ent. I didn't examine this behavior in detail, though, just adjusted the entities until it worked in both ports. 

I'm wondering if this is a known issue or if there are some relevant console settings I could tweak.

I've ripped my Quake CD to OGG and MP3 forms. When the soundtrack files are played using DarkPlaces, Fitzquake Mark V, or DirectQ, they sound "right". With QuakeSpasm though they don't.

My usual test track is the first one ("Aftermath") that plays during the intro demo as well as on DM4. In the "DA NA NA - DA NA NA NA" hits, correct playback has some high frequencies in there that give those hits some prickly edges, but in QuakeSpasm they just sound kindy sludgey. 

That's because the tracks are downsampled to 11025 Hz by default. With "-sndspeed 44100" they'll sound as expected. 

Thanks!

I've also run across the sndspeed "controversy" in the Fitzquake Mark V thread now. 

(Source only ..)

After making sure I was aware of all the Quakespasm changes, I carefully added a few Mark V features that I really miss when using Quakespasm on my Macs.

10 changed source files which go in Quake folder of Quakespasm source OR ... alternatively changes .diff file

The diff changes the version to "0.85.9" just so I could be certain that I was using the right one during testing.

Dynamic light speedup, record demo at any time, widescreen correction (as far as I know Quakespasm doesn't have this), and making the gun the same size regardless of the fov. 

...making the gun the same size regardless of the fov.

This. I guess this feature should be implemented in all engines currently active - at least as a cvar. Nice thought. 

 

r_gunangle
or
r_viewmodelfov

Usually does the trick... mine is set to this in the autoexec.cfg -

r_gunangle 2
or
r_viewmodelfov 110 

I have just tried the cvars you suggested in the latest QuakeSpasm... to no avail. They are sadly unrecognized. 

may have been forked from Fitz or something. :-/ 

Please try the svn version: we might be releasing a 0.85.9 soon(ish). Source snapshot and pre-built binaries are temporarily at: http://quakespasm.sourceforge.net/devel/ 

I have to say, after reviewing your code changes in detail super-detailed review of Quakespasm changes, I think Quakespasm with all things considered is the best Quake engine ever top to bottom measured by platform interoperability, project structure, debugging and convenience. 

I just looked over the changes between 8 and 9 and something MH would say goes like this:

You have IN_Activate and IN_Deactivate referenced everywhere, but really you should just check that in one place in the source once per frame.

Not that I've actually conquered this myself ... yet. Spike would recommend a Q3-like message queue (don't handle SDL messages immediately, queue them --- then handle once per frame --- so you have a single point of evaluation per frame and one place it happens).

In Mark V, this is a major goal to be in the late summer release. The way Quake handles input activation/deactivation is not good, case in point often in many engines if I ALT-TAB out and then back in, the brightness corrects and then it for some reason goes back to system normal (not what the Quake brightness option is set to).

If I can get a proper handle on this in the coming months --- after the feature is in a released Mark V for long enough to be considered road-tested -- I see if I can rework Quakespasm to use it. 

cheers for the patches Baker. 

Personally, I'm not very happy with our IN_Activate() & co being called from everywhere, either. It was done at some point during development of whichever version I can't remember, and it gradually got messier. It was partially adopted from uhexen2 but with more messiness. Needs addressing in newer versions, yes.

As for new version wrt your fov changes: I think they would not be needed anymore after the fov_adapt (Hor+) stuff, yes?

As for the demo changes: I know the idea is appealing, but I believe it needs a little more maturing? (esp. after reading the fog, etc. concerns in the code?) 

Both fog and skybox are hacks. They are read from worldspawn client-side [not via server svc] which violates client-server ideology.

Arguing against demo record in that context is like arguing against save games.

The issue is uncorrectable because to do it right, you would need the QuakeC source code to every map that uses a skybox to fix it. Except there are several dozens of closed source single player mods.

But Quakeworld has had demo record since 1996, ProQuake since 1999 and JoeQuake since 2003.

Do you tell people that want demo record --- and keep it mind that no demo record is recording that info, nor save games for that matter --- that because of design-flawed after-the-market implementations of fog/skybox [id Software's Quake didn't provide these, the after-the-market modification community did = all of us] that as a result you want to make it hard to record a demo?

Not that demos that record today in Quakespasm record skybox or fog -- because they don't.

I get your point and agree with it. Except we have to work with the world we've got, not the one we want.

How are the demos recorded in Quakespasm with say the "Necros savegame/loadgame trick alias" superior to the record at any time feature? They aren't.

So then the question just becomes user convenience.

But have you noticed an explosion of demo recordings lately? They are using Mark V.

I'm not trying to win an argument -- I view this with the same disappointed angle as you if you remember a discussion about mod cvars aren't recorded in Quake saves --- there isn't an absolute proper "win" to be had here.

Quake save games and demos are never going to record the entire server state. 

... has had demo record since ...
This sounds more like no other thing supports demo record, where you possibly mean ability to record after connect :)

I see your points, though. If Steve has no objections I can include the demo stuff in 0.85.9. 

OK then, applied the demo stuff at r847:
http://sourceforge.net/p/quakespasm/code/847/

So, v0.85.9 will support demo recording after connecting to server.
Will upload a source snapshot and prepare test binaries later today. 

Is it possible to continue recording a demo after level change or a reload (and demo would actually play back after reload point)? I know DP allows that, any other (hw accelerated win32) engine?

And any (again hw accelerated win32) engine that has internal not system gamma controls (again besides DP)

Posting in a top engine thread, but its about any engine. 

Anything that uses stuffcmds cannot be saved into saved games, and will need special care for clients that record mid-game.
Saying that the fog is part of the map is just about the least hacky way to do it, and will work in all saved games or demos, so long as there's no stuffcmds.

Its for this reason that csqc was designed to avoid random writebyte etc use, depending upon entities and stats. Stats can be trivially regenerated by the server (because they're dependant upon some global or field, and mapped correctly in the worldspawn function). Ents are regenerated automatically via the same mechanism that covers pvs, which must be present anyway. The fact that 515 added tempentity hacks to dp which got popularized by xonotic is a disapointment that breaks saved games all too easily.

Yes, saved games and demos will never record the entire state, but the key thing is that they don't have to - so long as the mod abstains from stuffcmd (and similar extensions). The rest can be reproduced from the state that is preserved.
Which is how mvds and qtv work. Note that mvds allow you to switch perspective from one player to another on the fly, while qtv is capable of adding new spectators mid game, all without access to the original game state.

TLDR version: stuffcmd is evil and cannot be supported properly. Stats rock. 

stuffcmd is evil and cannot be supported properly.
What do you suggest that MOD creators use instead of stuffcmd? I know several MODs that use stuffcmd to change fog parameters for example, how else can the MOD issue console commands without the echo to the console? 

<quote>Is it possible to continue recording a demo after level change or a reload (and demo would actually play back after reload point)?</quote>

IIRC, QuakeSpasm has support for that since v0.85.7. 

at: http://quakespasm.sourceforge.net/devel/

If nothing goes wrong, I guess I'll release this as v0.85.9.