@metlslime, @mh :

I was reported a stack buffer overrun in Mod_PolyForUnlitSurface
https://github.com/sezero/quakespasm/issues/100
Fixed easily by removing the hardcoded local verts and inlining
'convert edges back to a normal polygon' code into poly creation
as shown in the patch in there.

However, a similar local copy to a hardcoded local verts[64] is
also in GL_SubdivideSurface, and the same trick can not apply to
it. Its subroutine SubdividePolygon() checks for numverts > 60
and errors out if it is so, but GL_SubdivideSurface itself does
not check before copying to the stack buffer verts[64]: What is
a good solution here? Easy way out by erroring out if fa->polys->
numverts > 64 ?? 

I don't see an easy way to remove the arrays, since it's recursively creating new arrays as it goes. You could throw an error in GL_SubdivideSurface like you suggested. or do a warning and drop all of the remaining verts (leaving an incomplete polygon.) 

OK, will throw an error. Thank you. 

if surfaces are always convex polygons, GL_SubdivideSurface can pre-divide it into a number of “triangle fan” parts. that could be done inline by messing with the vertex array in place and keeping track and fixing it up as you go. then youre only sending safe data into the recursive function. 

If you can send me a patch (sezeroz _at_ gmail _dot_com) I can
gladly test and include it in the next release. If not, well, we
have never hit a stack overrun in GL_SubdivideSurface so far and
this was just a safeguard anyway. Thanks. 

Version 0.96.2 of QuakeSpasm is released.

Downloads:
https://sourceforge.net/projects/quakespasm/files/
http://quakespasm.sourceforge.net/download.htm

Changes since the previous version:

- Fix stack buffer overrun Mod_PolyForUnlitSurface: fixes crash when
loading lim_daviddg.bsp from Liminal Spaces Jam.
- Fix potential buffer overflow in progs global string functions.
- Fix potential buffer overflow in Mod_LoadAliasFrame()
- Optimize BoxOnPlaneSide()
- Reserve enough space in PF_makestatic() for worst case scenarios.
- Improve handling of huge entities in SV_FindTouchedLeafs()
- Warn about bad maps with only 1 or 2 edges per face (e.g.: mj4m?,
alk_dancing, ej3_bizz, rotj_entsoy...)
- Apply FOV gun scaling for r_showtris
- Sliders with visible values in options menu.
- game command now refuses setting a non-existing game directory
- Fix build in C23 mode.
- Minor code cleanups. Updated third party code, e.g. SDL, music
codecs, etc.
- Thanks to Andrei Drexler, Alexey Lysiuk, Diordany van Hemert, and
Jaime Moreira for patches. 

Version 0.96.3 of QuakeSpasm is released.

Downloads:
https://sourceforge.net/projects/quakespasm/files/
http://quakespasm.sourceforge.net/download.htm

Changes since the previous version:

- Fix potential infinite loop when playing sounds with loop start >= end
(e.g. misc/forcefield.wav from Madfox's kaptlog.zip)
- Fix possible overflow when resampling very big sounds (e.g. gram1.wav
from the 'A day like no other' mod.)
- Change Sky_ClipPoly to allocate on the heap in if MAX_CLIP_VERTS limit
is reached (e.g. with lim_daviddg from Liminal Spaces Jam)
- Minor code cleanups. Updates to third party code.
- Thanks to Andrei Drexler, Vincent Sonnier, Alexey Lysiuk, and Jaycie
Ewald for patches. 

any particular reason the

-"elevator sinking bug", (plus airquake tank turret updating bug)
-the "stuck on convex angle bug",

still not fixed after all these years?

...at least you guys fixed the mouse glitch bug 

Some bugs are content bugs in the maps, not engine bugs. 

i don't recall these bugs happening in winquake

particularly the "elevator sinking bug" (and airquake tank turret updating bug) 

the "elevator sinking bug" doesn't happen in it... 

Stuck on convex angle is 100% reproducible in ID Quake and happens in e1m1; it was fixed in the Kex reissue by altering the map geometry. 

I'm looking at this page but couldn't find such an option, does it exist? Thanks!

https://manpages.ubuntu.com/manpages/bionic/man1/quakespasm.1.html 

just adding “+map mapmame” should do it 

 

If you start and quit Quakespasm, multiple times (like 5-6),

the game will suddenly not boot up/be a black screen when you try to run it again 

Also sometimes Quakespasm will freeze or not be able to return to the game, after you minimize it 

Compound model monsters, like in Malice, often the upperbody/subordinate part missing), this bug doesn't happen in WinQuake 

You might want to file these bugs or check and see what the status is, if they have already been reported.

https://sourceforge.net/p/quakespasm/bugs/

https://github.com/sezero/quakespasm/issues 

@ dumptruck_ds I don't see this issue listed there?

also I've narrowed it down

something is wrong with QS's MOVETYPE_PUSH, MOVETYPE_NOCLIP, MOVETYPE_STEP... because when used for body compound mdl monsters, the attached body is either invisible or not updating fast enough - so looks jittery (like I mentioned these bugs don't happen in winquake) 

I don't have malice or whatever, therefore I don't know what it is about. If someone has a well-tested patch, that would be welcome of course. 

airquake tanks also have a similar problem... try it yourself; look at the enemy tanks' turrets when they drive around

https://www.moddb.com/mods/air-quake/downloads/airquake-103 

Do ironwail and/or vkquake (or any other source ports) have this issue? 

Do ironwail and/or vkquake (or any other source ports) have this issue?
yup

I think joequake or some port with the old quake underwater effect didn't have this issue 

OK, created a ticket for this at https://github.com/sezero/quakespasm/issues/118

(For future reference, I don't follow this thread daily, I just happened to notice it by chance: Please use the issue trackers that dumptruck_ds noted above, like everyone else, otherwise bug reports here will easily get forgotten.)