On my Windows 10 machine, I didn't experience any Poorchop/Johnny Law mouse oddities.

Makes me wonder if maybe I could cause the issue somehow by installing maybe new Direct X drivers? I don't know.

If I can't experience an issue, makes it tough to guess. The mouse was fine for me.

If Mark V 1036 download link doesn't experience the mouse issue on Johnny Law/PoorChop's machine, I would suspect the issue relates to DirectInput which 1.99 switched to.

If that is the case, I could make DirectInput turn on and off and maybe default off. 

make DirectInput turn on and off and maybe default off.

I'm thinking that's probably the best option.

After playing Mark V and setting my sensitivity to an appropriate value to account for dinput, if I then use some other engine or a different version of Mark V, my sensitivity is way too high!

Here's another thought: If dinput is being used, automatically double the sensitivity value (rather, treat the value as doubled). That would probably get rid of the need for the Sensitivity slider to go up much higher to account for dinput being much less sensitive.

And if people wanna be more precise (even with the doubling happening behind the scenes), they can use decimal values, like sensitivity 10.5

But doubling the Sensitivity value for dinput would probably feel very close to the standard Sensitivity value when dinput is not being used. 

Bummer that you couldn't reproduce. I gave Mark V another few tries within the past few weeks and I had the same exact issues that Johnny Law spoke of - sometimes -mouse1 didn't register so I was firing indefinitely. Previously I just thought it was neither +mouse1 nor -mouse1 registering.

I'll spend some time playing around in 1036 to see if it works fine for me. 

I'm about to go camping, but I'll remember to get back to this later. 

Guys take your time, it's the summer. But yeah, if either of you can find out if 1036 does or doesn't have the issue, it can really shed some light on the nature of the issue. 

I've tested long enough by now that I would've noticed if I was still having issues but I haven't had any problems with 1036. I spent a while bunny hopping and playing through maps, and all of my mouse clicks registered just fine.

On a side note, I am getting some pretty terrible performance outside of id1 maps but that's another issue. 

Thanks for info. Helps confirm thoughts on issue. 

May I trouble you to test one more build ...

The 1080 build. download

And tell me if you have the mouse issue with 1080.

The results from 1080 should allow me to conclusively and quickly do a patch fixing exactly the "right" thing. (The alternative is some guesswork and if I am wrong it could take 3 attempts.)

I'd like to resolve the "Poorchop/Johnny Law Windows 10 mouse issue" right the first time. 

I played through some id1 and bunny hopped around for a long time, but I didn't notice any issues with mouse clicks registering. v1080 seems to be working fine here as well. 

Thanks! 

FWIW I just played through Amphitheater Of Abaddon using build 1080 and didn't notice any problems. 

(and that was me) 

Defaults to gamma .75 I can confirm this as I've installed it into new directories 3x this week. I usually reset my config by hand BTW so it's defaulting for sure. 

Heads up that uwjam is performing pretty badly with this mod. Seems the sprites are causing significant framerate issues. I will test some more this evening but wanted to check with anyone else and see if they were experiencing issues.

I just played in QSS and did not experience the showdown. 

I haven't tested uwjam with Mark V but I've played a few other maps that have some frame rate issues despite running perfectly fine in other ports. Not really sure how to troubleshoot something like this though. 

The MarkV D3D9 sprite drawing code is particularly sensitive to high numbers of sprites and will suffer performance problems in those situations.

Basically it looks something like this:

for (int i = 0; i < numsprites; i++)
{
SetState ();
DrawSprite ();
UnSetState ();
}

In order to deal with D3D9's well-known draw call overhead problems, the D3D9 wrapper code attempts to concatenate multiple draw calls with the same state into a single draw call, so that the whole thing can run with fewer draw calls.

The MarkV code (inherited from FitzQuake, in turn inherited from GLQuake) prevents it from being able to do that, because making any state change will break a batch.

Changing it to something like this will help a lot:

SetState ();

for (int i = 0; i < numsprites; i++)
DrawSprite ();

UnSetState ();

By SetState and UnSetState I specifically mean the alpha test state here; the polygon offset state only happens with Hipnotic bullet-hole decals and should be rare enough, whereas texture changes are something that has to happen so that's a state change that you'll just swallow. But this change on it's own should go a long way towards fixing things up. 

Added to the list. 

Recursion is hated in lowest-level coding -- when you look at what is going on at the stack level.

Recursion causes tons of unnecessary stack push/pop slowing down what would be faster loop mechanics inside a single function.

Elegance hates "goto". Yet "goto" dominates the world and well-written low-level code is code that the compiler can reduce to "goto" form avoiding the use of recursion.

/The D3D9 sprite handling is making me think about how to best optimize sprites next round to fit how D3D9 wants the data fed. 

This is just similar to the technique for making dynamic lights go fast - if you have a bunch of work to do, dividing it into fewer large batches will always outperform many smaller batches. Beyond that it's just a matter of understanding what patterns can prevent fewer large batches, and in any 3D API (including native OpenGL) that's going to be things like unnecessary state changes. Typically brought on by things that seem "right", such as unbinding textures/buffers, or putting state back the way it was after drawing an object.

The Quake code is riddled with small inefficiencies and it's death by 1000 cuts. None of this mattered in 1996 when GLQuake only ran on high end workstations, and everybody else had a 3DFX which routed it's drawing through a layer which tried to make something sensible out of it.

Ever bought a new GPU and found that Quake ran no faster on it?

Recursion is going to be down in the noise in any Q1 performance graph. Any decent compiler will automatically generate the right optimized tail-recursion code for you, without you needing to resort to tricksy or cutesy obfuscation. Don't waste time on the small beans.

In an ideal world that D3D9 code would not be needed; you could rip it out tomorrow and start investing time in making your OpenGL go fast, which IMO would be preferable to trying to make the 2 APIs coexist peacefully. The big secret is that Intel graphics are no longer crap, and haven't been for a long time. It's not Intel graphics, it's Quake's use of OpenGL that's crap.

As a general rule, bad OpenGL code will go faster than bad D3D code. But good D3D code will go faster than good OpenGL code. But in order to get good D3D code you need to go native and start writing code that's tailored to D3D's strengths; trying to translate bad GL code into something that tries to do the right thing in D3D can only get so far and will always throw up unexpected glitches and bottlenecks - like the sprites case. 

I was thinking of qmb and to some extent Nehahra extra effects that are in the engine (above and beyond stock Quake sprites). qmb is highly recursed. 

Ah, I'm not familiar with the QMB code although I've been aware of the effects since almost the very beginning. That's something I must rectify. 

I took a look at the real-time lighting prototype you made a few hours ago.

Looking at the source, I thought the dates were funny because you wrote it at the same time as the DX9 wrapper. 

How do I enable vsync and set color depth in Mark V? And for a Quakespasmer just coming around to Mark V, what are some of the notable differences between Mark V and QS, ie. what's the reason behind developing two separate engines that do a lot of the same things? 

vid_vsync 1 (I think away from PC)

Mark V in DirectX 9, has mouse driven menus (if you get used to it and go to QS - you'll miss it), levels menu item, demos menu item, you can fast forward demos, some developer tools and a "find" function in the console - which is handy.

Quakespasm has excellent performance and compatibility with mods etc is very good. But I prefer Mark V overall for the reasons above.